Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

From: David Miller
Date: Thu Jun 27 2019 - 12:22:56 EST


From: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 26 Jun 2019 21:32:52 -0600

> On 6/26/19 9:25 PM, Jiunn Chang wrote:
>> Shifting signed 32-bit value by 31 bits is undefined. Changing most
>> significant bit to unsigned.
>> Changes included in v2:
>> - use subsystem specific subject lines
>> - CC required mailing lists
>>
>
> These version change lines don't belong in the change log.

For networking changes I actually like the change lines to be in the
commit log. So please don't stray people this way, thanks.