Re: [PATCH] platform/chrome: lightbar: Get drvdata from parent in suspend/resume

[Gwendal Grignou]

Reviewed-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>


On Thu, Jun 27, 2019 at 2:47 PM Rajat Jain <rajatja@xxxxxxxxxx> wrote:
>
> The lightbar driver never assigned the drvdata in probe method, and
> thus there is nothing there. Need to get the ec_dev from the parent's
> drvdata.
>
> Signed-off-by: Rajat Jain <rajatja@xxxxxxxxxx>
> ---
>  drivers/platform/chrome/cros_ec_lightbar.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index d30a6650b0b5..26117a8991b3 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -600,7 +600,7 @@ static int cros_ec_lightbar_remove(struct platform_device *pd)
>
>  static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>  {
> -       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>
>         if (userspace_control)
>                 return 0;
> @@ -610,7 +610,7 @@ static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>
>  static int __maybe_unused cros_ec_lightbar_suspend(struct device *dev)
>  {
> -       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>
>         if (userspace_control)
>                 return 0;
> --
> 2.22.0.410.gd8fdbe21b5-goog
>