Re: [PATCH] powerpc/64s/radix: Define arch_ioremap_p4d_supported()
From: Anshuman Khandual
Date: Thu Jun 27 2019 - 23:44:35 EST
On 06/27/2019 10:18 AM, Michael Ellerman wrote:
> Anshuman Khandual <anshuman.khandual@xxxxxxx> writes:
>> Recent core ioremap changes require HAVE_ARCH_HUGE_VMAP subscribing archs
>> provide arch_ioremap_p4d_supported() failing which will result in a build
>> failure like the following.
>>
>> ld: lib/ioremap.o: in function `.ioremap_huge_init':
>> ioremap.c:(.init.text+0x3c): undefined reference to
>> `.arch_ioremap_p4d_supported'
>>
>> This defines a stub implementation for arch_ioremap_p4d_supported() keeping
>> it disabled for now to fix the build problem.
>
> The easiest option is for this to be folded into your patch that creates
> the requirement for arch_ioremap_p4d_supported().
>
> Andrew might do that for you, or you could send a v2.
>
> This looks fine from a powerpc POV:
>
> Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>
> cheers
Hello Stephen/Michael/Andrew,
On linux-next (next-20190627) this change has already been applied though a
merge commit 153083a99fe431 ("Merge branch 'akpm-current/current'"). So we
are good on this ? Or shall I send out a V2 for the original patch. Please
suggest. Thank you.
- Anshuman