Re: [PATCH] crypto: asymmetric_keys - select CRYPTO_HASH where needed

From: Herbert Xu
Date: Fri Jun 28 2019 - 00:20:01 EST


On Tue, Jun 18, 2019 at 02:13:47PM +0200, Arnd Bergmann wrote:
> Build testing with some core crypto options disabled revealed
> a few modules that are missing CRYPTO_HASH:
>
> crypto/asymmetric_keys/x509_public_key.o: In function `x509_get_sig_params':
> x509_public_key.c:(.text+0x4c7): undefined reference to `crypto_alloc_shash'
> x509_public_key.c:(.text+0x5e5): undefined reference to `crypto_shash_digest'
> crypto/asymmetric_keys/pkcs7_verify.o: In function `pkcs7_digest.isra.0':
> pkcs7_verify.c:(.text+0xab): undefined reference to `crypto_alloc_shash'
> pkcs7_verify.c:(.text+0x1b2): undefined reference to `crypto_shash_digest'
> pkcs7_verify.c:(.text+0x3c1): undefined reference to `crypto_shash_update'
> pkcs7_verify.c:(.text+0x411): undefined reference to `crypto_shash_finup'
>
> This normally doesn't show up in randconfig tests because there is
> a large number of other options that select CRYPTO_HASH.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> crypto/asymmetric_keys/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt