Re: No 8254 PIT & no HPET on new Intel N3350 platforms causes kernel panic during early boot
From: Thomas Gleixner
Date: Fri Jun 28 2019 - 01:08:11 EST
On Fri, 28 Jun 2019, Daniel Drake wrote:
> On Thu, Jun 27, 2019 at 10:07 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > Nah. That extra timer works thing is just another bandaid.
> >
> > What I had in mind is something like the below. That's on top of
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/apic
> >
> > Be warned. It's neither compiled nor tested, so keep a fire extinguisher
> > handy. If it explodes you own the pieces.
>
> Thanks, it works, and makes sense!
>
> I'll add a commit message and send it as a patch, just one quick
> function naming question... did you mean apic_and_tsc_needs_pit() or
> apic_needs_pit()? That's the only compile fix needed.
I'd say apic_needs_pit(). Less places to change :)
Thanks,
tglx