Re: [PATCH] ALSA: usb-audio: fix sign unintended sign extension on left shifts

From: Takashi Iwai
Date: Fri Jun 28 2019 - 04:38:00 EST


On Thu, 27 Jun 2019 18:43:08 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> There are a couple of left shifts of unsigned 8 bit values that
> first get promoted to signed ints and hence get sign extended
> on the shift if the top bit of the 8 bit values are set. Fix
> this by casting the 8 bit values to unsigned ints to stop the
> unintentional sign extension.
>
> Addresses-Coverity: ("Unintended sign extension")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied now. Thanks.


Takashi