Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64

[Andreas Schwab]

On Jun 28 2019, Christophe Leroy <christophe.leroy@xxxxxx> wrote:

> Le 28/06/2019 Ã 18:36, Andreas Schwab a ÃcritÂ:
>> On Jun 28 2019, Christophe Leroy <christophe.leroy@xxxxxx> wrote:
>>
>>> diff --git a/arch/powerpc/include/uapi/asm/ptrace.h b/arch/powerpc/include/uapi/asm/ptrace.h
>>> index f5f1ccc740fc..37d7befbb8dc 100644
>>> --- a/arch/powerpc/include/uapi/asm/ptrace.h
>>> +++ b/arch/powerpc/include/uapi/asm/ptrace.h
>>> @@ -43,12 +43,11 @@ struct pt_regs
>>>   	unsigned long link;
>>>   	unsigned long xer;
>>>   	unsigned long ccr;
>>> -#ifdef __powerpc64__
>>> -	unsigned long softe;		/* Soft enabled/disabled */
>>> -#else
>>> -	unsigned long mq;		/* 601 only (not used at present) */
>>> +	union {
>>> +		unsigned long softe;	/* Soft enabled/disabled */
>>> +		unsigned long mq;	/* 601 only (not used at present) */
>>>   					/* Used on APUS to hold IPL value. */
>>> -#endif
>>> +	};
>>
>> Anonymous unions are a C11 feature.
>>
>
> Is that a problem ?

Yes, this is a UAPI header.

Andreas.

-- 
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."