Re: [PATCH V5 02/18] pinctrl: tegra: Add suspend and resume support

[Sowjanya Komatineni]

On 6/28/19 5:05 AM, Dmitry Osipenko wrote:
> 28.06.2019 14:56, Dmitry Osipenko ÐÐÑÐÑ:
> > 28.06.2019 5:12, Sowjanya Komatineni ÐÐÑÐÑ:
> > > This patch adds support for Tegra pinctrl driver suspend and resume.
> > >
> > > During suspend, context of all pinctrl registers are stored and
> > > on resume they are all restored to have all the pinmux and pad
> > > configuration for normal operation.
> > >
> > > Acked-by: Thierry Reding <treding@xxxxxxxxxx>
> > > Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
> > > ---
> > >   int tegra_pinctrl_probe(struct platform_device *pdev,
> > >   			const struct tegra_pinctrl_soc_data *soc_data);
> > >   #endif
> > > diff --git a/drivers/pinctrl/tegra/pinctrl-tegra210.c b/drivers/pinctrl/tegra/pinctrl-tegra210.c
> > > index 0b56ad5c9c1c..edd3f4606cdb 100644
> > > --- a/drivers/pinctrl/tegra/pinctrl-tegra210.c
> > > +++ b/drivers/pinctrl/tegra/pinctrl-tegra210.c
> > > @@ -1571,6 +1571,7 @@ static struct platform_driver tegra210_pinctrl_driver = {
> > >   	.driver = {
> > >   		.name = "tegra210-pinctrl",
> > >   		.of_match_table = tegra210_pinctrl_of_match,
> > > +		.pm = &tegra_pinctrl_pm,
> > >   	},
> > >   	.probe = tegra210_pinctrl_probe,
> > >   };
> > Could you please address my comments in the next revision if there will be one?
> Also, what about adding ".pm' for other Tegras? I'm sure Jon could test them for you.

This series is for Tegra210 SC7 entry/exit along with clocks and pinctrl 
suspend resume needed for Tegra210 basic sc7 entry and exit.

This includes pinctrl, pmc changes, clock-tegra210 driver changes all 
w.r.t Tegra210 platforms specific.

Suspend/resume support for other Tegras will be in separate patch series.


thanks

Sowjanya