Re: [GIT PULL] Hisilicon fixes for v5.2

[Wei Xu]

Hi Olof,

On 2019/6/27 10:19, Olof Johansson wrote:
> On Tue, Jun 25, 2019 at 02:31:26PM +0100, John Garry wrote:
> > On 25/06/2019 14:03, Olof Johansson wrote:
> > > > > are available in the Git repository at:
> > > > > > >    git://github.com/hisilicon/linux-hisi.git tags/hisi-fixes-for-5.2
> > > > > > >
> > > > > > > for you to fetch changes up to 07c811af1c00d7b4212eac86900b023b6405a954:
> > > > > > >
> > > > > > >    lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set at registration (2019-06-25 09:40:42 +0100)
> > > > > > >
> > > > > > > ----------------------------------------------------------------
> > > > > > > Hisilicon fixes for v5.2-rc
> > > > > > >
> > > > > > > - fixed RCU usage in logical PIO
> > > > > > > - Added a function to unregister a logical PIO range in logical PIO
> > > > > > >    to support the fixes in the hisi-lpc driver
> > > > > > > - fixed and optimized hisi-lpc driver to avoid potential use-after-free
> > > > > > >    and driver unbind crash
> > > > > Merged to fixes, thanks.
> > > This broke arm64 allmodconfig:
> > >
> > >         arm64.allmodconfig:
> > > drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function
> > > 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'?
> > > [-Werror=implicit-function-declaration]
> > Uhhh, that's my fault - I didn't provide a stub for !ACPI. Sorry. I'll send
> > a fixed v3 series.
> No worries, it happens -- but it's good if maintainers do at least a few test
> builds before sending in pull requests so we don't catch all of it at our end.

Sorry for the late reply!
I had a trip last week and did the pull request in a hurry that forgot 
to do the some building
test like allmodconfig, allyesconfig and so on.
In the future, I will do more testing before sending out to avoid this 
kind fault.

Best Regards,
Wei

> -Olof
>
> .