Re: [PATCH] locking/lockdep: clean up #ifdef checks

From: Peter Zijlstra
Date: Mon Jul 01 2019 - 04:23:46 EST


On Fri, Jun 28, 2019 at 12:03:54PM +0100, Will Deacon wrote:
> Hi Arnd,
>
> On Fri, Jun 28, 2019 at 12:29:03PM +0200, Arnd Bergmann wrote:
> > As Will Deacon points out, CONFIG_PROVE_LOCKING implies TRACE_IRQFLAGS,
> > so the conditions I added in the previous patch, and some others in the
> > same file can be simplified by only checking for the former.
> >
> > No functional change.
> >
> > Fixes: 886532aee3cd ("locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > ---
> > kernel/locking/lockdep.c | 13 ++++++-------
> > 1 file changed, 6 insertions(+), 7 deletions(-)
>
> Thanks for following up on this. I think it makes the code easier to read,
> so:
>
> Acked-by: Will Deacon <will@xxxxxxxxxx>

Thanks guys!