Re: [PATCH v3] Staging: most: fix coding style issues

From: kbuild test robot
Date: Mon Jul 01 2019 - 09:41:30 EST


Hi Gabriel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.2-rc6 next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Gabriel-Beauchamp/Staging-most-fix-coding-style-issues/20190701-203804
config: i386-randconfig-x074-201926 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-9) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/staging/most/core.c: In function 'set_datatype_show':
>> drivers/staging/most/core.c:308:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
type = ch_data_type[i].name;
^

vim +/const +308 drivers/staging/most/core.c

296
297 static ssize_t set_datatype_show(struct device *dev,
298 struct device_attribute *attr,
299 char *buf)
300 {
301 int i;
302 char *type = "unconfigured\n";
303
304 struct most_channel *c = to_channel(dev);
305
306 for (i = 0; i < ARRAY_SIZE(ch_data_type); i++) {
307 if (c->cfg.data_type & ch_data_type[i].most_ch_data_type) {
> 308 type = ch_data_type[i].name;
309 break;
310 }
311 }
312 return snprintf(buf, PAGE_SIZE, "%s", type);
313 }
314

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip