RE: [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for blinking leds

[Ong, Hean Loong]

Thank you Dinh

Best Regards,

Hean Loong
Internal Global Dial: 2 701 6773
Direct Line: +60 4 636 6773


>-----Original Message-----
>From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
>Sent: Monday, July 1, 2019 11:55 PM
>To: Ong, Hean Loong <hean.loong.ong@xxxxxxxxx>; Thayer, Thor
><thor.thayer@xxxxxxxxx>
>Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; See,
>Chin Liang <chin.liang.see@xxxxxxxxx>
>Subject: Re: [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for
>blinking leds
>
>
>
>On 6/27/19 9:07 AM, Ong, Hean Loong wrote:
>> Adding LED Triggers Timers for LED blinking support on ARM devices
>>
>> Signed-off-by: Ong, Hean Loong <hean.loong.ong@xxxxxxxxx>
>> ---
>>  arch/arm64/configs/defconfig |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/configs/defconfig
>> b/arch/arm64/configs/defconfig index 4d58351..6fbd651 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -595,6 +595,7 @@ CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>> CONFIG_LEDS_TRIGGER_CPU=y  CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>> CONFIG_LEDS_TRIGGER_PANIC=y
>> +CONFIG_LEDS_TRIGGER_TIMER=y
>>  CONFIG_EDAC=y
>>  CONFIG_EDAC_GHES=y
>>  CONFIG_RTC_CLASS=y
>>
>
>I've applied this patch with this change:
>
>--- a/arch/arm64/configs/defconfig
>+++ b/arch/arm64/configs/defconfig
>@@ -590,6 +590,7 @@ CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_GPIO=y
> CONFIG_LEDS_PWM=y
> CONFIG_LEDS_SYSCON=y
>+CONFIG_LEDS_TRIGGER_TIMER=y
> CONFIG_LEDS_TRIGGER_DISK=y defconfig
> CONFIG_LEDS_TRIGGER_HEARTBEAT=y
> CONFIG_LEDS_TRIGGER_CPU=y
>
>Also, the commit header should be "arm64: defconfig".
>
>Dinh