RE: [PATCH V2] soc: imx-scu: Add SoC UID(unique identifier) support

[Anson Huang]

Hi, Marco

> > +	hdr->ver = IMX_SC_RPC_VERSION;
> > +	hdr->svc = IMX_SC_RPC_SVC_MISC;
> > +	hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
> > +	hdr->size = 1;
> > +
> > +	/*
> > +	 * SCU FW API always returns an error even the
> > +	 * function is successfully executed, so skip
> > +	 * returned value check.
> > +	 */
> > +	imx_scu_call_rpc(soc_ipc_handle, &msg, true);
> 
> Please can you add a TODO: or FIXME: tag and also provide the firmware
> version containing the bug? I know that developers are very busy and follow-
> up fixes never reach mainline ;)

As I replied in previous mail, I will send out a V3 with below comment:

+       /*
+        * SCU FW API does NOT have returned value for
+        * this function, so skip returned value check.
+        */
+       imx_scu_call_rpc(soc_ipc_handle, &msg, true);

Thanks,
Anson.

> 
> Regards,
>   Marco