Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

From: Keerthy
Date: Tue Jul 02 2019 - 07:36:28 EST




On 02/07/19 5:01 PM, Lee Jones wrote:
On Tue, 02 Jul 2019, Colin Ian King wrote:

On 02/07/2019 11:44, Lee Jones wrote:
On Fri, 28 Jun 2019, Colin Ian King wrote:

On 28/06/2019 15:36, Mark Brown wrote:
On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a
break statement, causing it to fall through to a dev_err message.
Fix this by adding in the missing break statement.

This doesn't apply against current code, please check and resend.

So it applies cleanly against linux-next, I think the original code
landed in mfd/for-mfd-next - c.f. https://lkml.org/lkml/2019/5/28/550

Applied, thanks Colin.

I'm confused, who is the official maintainer of the regulator patches
nowadays?

Mark. But the patch you're fixing is currently in the MFD tree.

I sent him an updated pull-request.

Thanks Lee!


Don't worry mate, you're in good hands. ;)