Re: [PATCH v3] mm/z3fold.c: Lock z3fold page before __SetPageMovable()

From: Shakeel Butt
Date: Tue Jul 02 2019 - 20:59:18 EST


On Tue, Jul 2, 2019 at 4:35 PM Henry Burns <henryburns@xxxxxxxxxx> wrote:
>
> Following zsmalloc.c's example we call trylock_page() and unlock_page().
> Also make z3fold_page_migrate() assert that newpage is passed in locked,
> as per the documentation.
>
> Link: http://lkml.kernel.org/r/20190702005122.41036-1-henryburns@xxxxxxxxxx
> Signed-off-by: Henry Burns <henryburns@xxxxxxxxxx>
> Suggested-by: Vitaly Wool <vitalywool@xxxxxxxxx>
> Acked-by: Vitaly Wool <vitalywool@xxxxxxxxx>
> Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
> Cc: Shakeel Butt <shakeelb@xxxxxxxxxx>
> Cc: Vitaly Vul <vitaly.vul@xxxxxxxx>
> Cc: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>
> Cc: Xidong Wang <wangxidong_97@xxxxxxx>
> Cc: Jonathan Adams <jwadams@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

We need a "Fixes" tag.

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>