Re: [PATCH] pci/proc: Use seq_puts() in show_device()
From: Bjorn Helgaas
Date: Tue Jul 02 2019 - 21:03:08 EST
On Tue, Jul 02, 2019 at 01:26:27PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 2 Jul 2019 13:21:33 +0200
>
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function âseq_putsâ.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Applied to pci/misc for v5.3, thanks!
> ---
> drivers/pci/proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
> index 445b51db75b0..fe7fe678965b 100644
> --- a/drivers/pci/proc.c
> +++ b/drivers/pci/proc.c
> @@ -377,7 +377,7 @@ static int show_device(struct seq_file *m, void *v)
> }
> seq_putc(m, '\t');
> if (drv)
> - seq_printf(m, "%s", drv->name);
> + seq_puts(m, drv->name);
> seq_putc(m, '\n');
> return 0;
> }
> --
> 2.22.0
>