Re: [PATCH v2 3/3] augmented rbtree: rework the RB_DECLARE_CALLBACKS macro definition

From: Michel Lespinasse
Date: Tue Jul 02 2019 - 21:12:38 EST


On Tue, Jul 2, 2019 at 4:52 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > - Reorder the RB_DECLARE_CALLBACKS macro arguments, following the
> > style of the INTERVAL_TREE_DEFINE macro, so that RBSTATIC and RBNAME
> > are passed last.
>
> That's, IMO, a weird change. C has storage type and name first, why
> would you want to put that last. If anything, change
> INTERVAL_TREE_DEFINE().

Makes sense, will do. I'll have to make it a v3 of the patchset
because RB_DECLARE_CALLBACKS_MAX was introduced with the opposite
argument order. Oh well, no big deal.

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.