RE: [LINUX PATCH v17 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

From: Naga Sureshkumar Relli
Date: Wed Jul 03 2019 - 02:13:52 EST


Hi Miquel,

> -----Original Message-----
> From: linux-mtd <linux-mtd-bounces@xxxxxxxxxxxxxxxxxxx> On Behalf Of Helmut Grohne
> Sent: Tuesday, June 25, 2019 7:41 PM
> To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> Cc: vigneshr@xxxxxx; bbrezillon@xxxxxxxxxx; yamada.masahiro@xxxxxxxxxxxxx;
> richard@xxxxxx; linux-kernel@xxxxxxxxxxxxxxx; marek.vasut@xxxxxxxxx; linux-
> mtd@xxxxxxxxxxxxxxxxxxx; miquel.raynal@xxxxxxxxxxx; computersforpeace@xxxxxxxxx;
> dwmw2@xxxxxxxxxxxxx
> Subject: Re: [LINUX PATCH v17 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353
> smc nand interface
>
> Thank you for the quick update.
>
> On Tue, Jun 25, 2019 at 06:46:30AM +0200, Naga Sureshkumar Relli wrote:
> > -> Tested Micron MT29F2G08ABAEAWP (On-die capable) and AMD/Spansion
> S34ML01G1.
>
> I tested the v17 series with the MT29F2G08ABAEAWP. I can now mount existing jffs2
> volumes without issues.
>
> When running nandtest on a 64MB area, I no longer see lots of consecutive errors. However I
> see few (4-8) single byte errors for random locations on about half the runs. In comparison, I
> couldn't reproduce these on the older driver on v4.14.
>
> When writing random 1MB files on a fresh jffs2 filesystem and reading them back after
> umounting and mounting the filesystem, I got one faulty file in 50 attempts.
>
> So this driver mostly works for me, but I suspect that something (possibly the tested
> hardware) doesn't fully work yet. To say more, I'll need long term testing results. In the mean
> time, I'm in favour of merging the driver.
What is your take on this?
Can we consider to merge this driver?
Could you please let me know?

Thanks,
Naga Sureshkumar Relli
>
> Helmut
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/