Re: [PATCH v3] pinctrl: qcom: Add irq_enable callback for msm gpio

[Linus Walleij]

On Tue, Jun 25, 2019 at 4:14 PM Neeraj Upadhyay <neeraju@xxxxxxxxxxxxxx> wrote:

> From: Srinivas Ramana <sramana@xxxxxxxxxxxxxx>
>
> Introduce the irq_enable callback which will be same as irq_unmask
> except that it will also clear the status bit before unmask.
>
> This will help in clearing any erroneous interrupts that would
> have got latched when the interrupt is not in use.
>
> There may be devices like UART which can use the same gpio line
> for data rx as well as a wakeup gpio when in suspend. The data that
> was flowing on the line may latch the interrupt and when we enable
> the interrupt before going to suspend, this would trigger the
> unexpected interrupt. This change helps clearing the interrupt
> so that these unexpected interrupts gets cleared.
>
> Signed-off-by: Srinivas Ramana <sramana@xxxxxxxxxxxxxx>
> Signed-off-by: Neeraj Upadhyay <neeraju@xxxxxxxxxxxxxx>
> ---
>
> Changes since v2:
> - Renamed function to msm_gpio_irq_clear_unmask()

Patch applied, unless Bjorn complains!

Yours,
Linus Walleij