Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs

[Greg KH]

On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote:
> Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs.
> 
> Signed-off-by: jeyentam <je.yen.tam@xxxxxx>
> ---
>  include/linux/pci_ids.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

You have read the comment at the top of this file, right?  If so, why
are you adding these entries?

> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 70e86148cb1e..7fad4794789f 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -1027,7 +1027,9 @@
>  #define PCI_DEVICE_ID_SUN_TOMATILLO	0xa801
>  #define PCI_DEVICE_ID_SUN_CASSINI	0xabba
>  
> +/* NI-Serial Device IDs */
>  #define PCI_VENDOR_ID_NI		0x1093

That's a vendor id, not a serial device id.

thanks,

greg k-h