Re: [PATCH 5/7 v2] MIPS: use the generic uncached segment support in dma-direct

[Arnd Bergmann]

On Mon, Jun 3, 2019 at 8:50 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Wed, May 01, 2019 at 05:13:57PM +0000, Paul Burton wrote:
> > Hi Christoph,
> >
> > On Wed, May 01, 2019 at 03:13:39PM +0200, Christoph Hellwig wrote:
> > > Stop providing our arch alloc/free hooks and just expose the segment
> > > offset instead.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > > ---
> > >  arch/mips/Kconfig              |  1 +
> > >  arch/mips/include/asm/page.h   |  3 ---
> > >  arch/mips/jazz/jazzdma.c       |  6 ------
> > >  arch/mips/mm/dma-noncoherent.c | 26 +++++++++-----------------
> > >  4 files changed, 10 insertions(+), 26 deletions(-)
> >
> > This one looks good to me now, for patches 1 & 5:
> >
> >   Acked-by: Paul Burton <paul.burton@xxxxxxxx>
>
> Thanks, I've merged thos into the dma-mapping tree.

I think this is the cause of some kernelci failures in current
linux-next builds:

https://kernelci.org/build/next/branch/master/kernel/next-20190702/

bigsur_defconfig â mips3 warnings â 1 error
cavium_octeon_defconfig â mips3 warnings â 1 error
ip27_defconfig â mips3 warnings â 1 error
loongson3_defconfig â mips3 warnings â 1 error
mips_paravirt_defconfig â mips3 warnings â 1 error
nlm_xlp_defconfig â mips3 warnings â 1 error
nlm_xlr_defconfig â mips1 warning â 1 error

/home/buildslave/workspace/workspace/kernel-build@8/linux/build/../kernel/dma/direct.c:144:
undefined reference to `arch_dma_prep_coherent'
2/home/buildslave/workspace/kernel-build/linux/build/../kernel/dma/direct.c:144:
undefined reference to `arch_dma_prep_coherent'
2(.text+0xafc): undefined reference to `arch_dma_prep_coherent'
1direct.c:(.text+0x934): undefined reference to `arch_dma_prep_coherent'
1(.text+0xb84): undefined reference to `arch_dma_prep_coherent'

I haven't looked into the details, but I suspect all machines
with cache-coherent DMA are broken.

       Arnd