Re: [PATCH] fs/seq_file: Replace a seq_printf() call by seq_puts() in seq_hex_dump()

From: Enrico Weigelt, metux IT consult
Date: Wed Jul 03 2019 - 05:53:53 EST


On 02.07.19 18:38, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 2 Jul 2019 18:28:10 +0200
>
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function âseq_putsâ.

Looks good, but have you checked whether "m" could ever be NULL and
whether seq_puts() has a check for that ?


--mtx

--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287