Re: Aw: Re: [PATCH 3/3] add driver and MAINTAINERS for poweroff

[Matthias Brugger]

On 03/07/2019 10:51, Frank Wunderlich wrote:
> Hi Mathias
> 
> thank you for first look on this. Patchseries is originally from Josef Friedl i got some time ago for getting poweroff working on bananapi r2. There it works and maybe on another devices too.
> 
> drivers/rtc/rtc-mt6397.c and drivers/rtc/rtc-mt7622.c look very differently on a diff (you've commented in part 1/3)
> 
> maybe code is compatible but i have not the knowledge to compare this...maybe sean (sorry, that i missed you) or ryder can say a word about the compatibility.
> 

My fault, I didn't got that right. So you are just improving the code of the RTC
driver. Which is great, but as already said, do this in a separate patch. :)

Regards,
Matthias

>> Fix the commit message. MAINTAINERS get normally send a independent patch.
>> Split patches between RTC and PWRC.
>> If not a new patch it should be stated in the commit message at least.
> 
> i will try to split this
> 
>>> + * Author: Tianping.Fang <tianping.fang@xxxxxxxxxxxx>
>>> + *        Sean Wang <sean.wang@xxxxxxxxxxxx>
>>
>> You are the author of this file, aren't you?
> 
> no, afaik these is code taken from rtc-mt6397.c and put in a separate header-file to use it in multiple c-files.
> 
> sidenote on encoding/word-wrap. i use only "git sendemail" which afaik calls sendmail (no other mta like thunderbird or similar) on ubuntu 18.4....curently have no idea how to fix this...have searched before, but not yet found anything. if you have an idea please give me a hint.
> 
> regards Frank
>