Re: [PATCH v2 2/2] media: hantro: Add support for VP8 decoding on rk3288

From: Boris Brezillon
Date: Wed Jul 03 2019 - 08:32:50 EST


On Tue, 2 Jul 2019 14:00:16 -0300
Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> wrote:

> diff --git a/drivers/staging/media/hantro/rk3288_vpu_hw.c b/drivers/staging/media/hantro/rk3288_vpu_hw.c
> index bcacc4f51093..470e803e25a6 100644
> --- a/drivers/staging/media/hantro/rk3288_vpu_hw.c
> +++ b/drivers/staging/media/hantro/rk3288_vpu_hw.c
> @@ -74,6 +74,19 @@ static const struct hantro_fmt rk3288_vpu_dec_fmts[] = {
> .step_height = MPEG2_MB_DIM,
> },
> },
> + {
> + .fourcc = V4L2_PIX_FMT_VP8_FRAME,
> + .codec_mode = HANTRO_MODE_VP8_DEC,
> + .max_depth = 2,
> + .frmsize = {
> + .min_width = 48,
> + .max_width = 3840,
> + .step_width = 16,
> + .min_height = 48,
> + .max_height = 2160,
> + .step_height = 16,

Can you define VP8_MB_DIM and use if for step_{width,height} (as done
for MPEG2 and H264)?

Looks good otherwise:

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

> + },
> + },
> };