Re: [PATCH v4 2/2] KVM: LAPIC: remove the trailing newline used in the fmt parameter of TP_printk

From: Paolo Bonzini
Date: Wed Jul 03 2019 - 10:14:28 EST


On 14/06/19 03:15, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@xxxxxxxxxxx>
>
> The trailing newlines will lead to extra newlines in the trace file
> which looks like the following output, so remove it.
>
> qemu-system-x86-15695 [002] ...1 15774.839240: kvm_hv_timer_state: vcpu_id 0 hv_timer 1
>
> qemu-system-x86-15695 [002] ...1 15774.839309: kvm_hv_timer_state: vcpu_id 0 hv_timer 1
>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>
> Signed-off-by: Wanpeng Li <wanpengli@xxxxxxxxxxx>
> ---
> arch/x86/kvm/trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index 4d47a26..b5c831e 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -1365,7 +1365,7 @@ TRACE_EVENT(kvm_hv_timer_state,
> __entry->vcpu_id = vcpu_id;
> __entry->hv_timer_in_use = hv_timer_in_use;
> ),
> - TP_printk("vcpu_id %x hv_timer %x\n",
> + TP_printk("vcpu_id %x hv_timer %x",
> __entry->vcpu_id,
> __entry->hv_timer_in_use)
> );
>

Queued 2/2, thanks.

Paolo