Re: [PATCH v2 32/35] omfs: Use kmemdup rather than duplicating its implementation

From: Bob Copeland
Date: Wed Jul 03 2019 - 12:57:09 EST


On Thu, Jul 04, 2019 at 12:31:58AM +0800, Fuqian Huang wrote:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.

Acked-by: Bob Copeland <me@xxxxxxxxxxxxxxx>

--
Bob Copeland %% https://bobcopeland.com/