Re: [PATCH v7 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

[Helen Koike]

On 7/3/19 4:59 PM, Thomas Gleixner wrote:
> Helen,
> 
> On Wed, 3 Jul 2019, Helen Koike wrote:
> 
>> @@ -0,0 +1,412 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Rockchip MIPI Synopsys DPHY driver
>> + *
>> + * Based on:
>> + *
>> + * Copyright (C) 2016 FuZhou Rockchip Co., Ltd.
>> + * Author: Yakir Yang <ykk@@rock-chips.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License.
> 
> So the SPDX-Identifiers says: GPL-2.0+ and here someone copied a broken
> boiler plate text which could be interpreted as GPLv2 only because the 'or
> at your option any later version' part was removed.
> 
> Can you please remove that boiler plate language? It's redundant
> information. The SPDX license identifier is unambiguous, machine readable
> and legally binding license information.
> 
> Thanks,
> 
> 	tglx
> 

Sure, thanks, I'll update it for the next version.
Helen