RE: [PATCHv5 00/20] PCI: mobiveil: fixes for Mobiveil PCIe Host Bridge IP driver

[Z.q. Hou]

Hi Lorenzo,

Thanks a lot for your comments!

> -----Original Message-----
> From: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Sent: 2019年7月3日 18:33
> To: Z.q. Hou <zhiqiang.hou@xxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> bhelgaas@xxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> l.subrahmanya@xxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; Leo Li
> <leoyang.li@xxxxxxx>; catalin.marinas@xxxxxxx; will.deacon@xxxxxxx;
> Mingkai Hu <mingkai.hu@xxxxxxx>; M.h. Lian <minghuan.lian@xxxxxxx>;
> Xiaowei Bao <xiaowei.bao@xxxxxxx>
> Subject: Re: [PATCHv5 00/20] PCI: mobiveil: fixes for Mobiveil PCIe Host
> Bridge IP driver
> 
> On Fri, Apr 12, 2019 at 08:35:11AM +0000, Z.q. Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> >
> > This patch set is to add fixes for Mobiveil PCIe Host driver.
> > And these patches are splited from the thread below:
> >
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> work.ozlabs.org%2Fproject%2Flinux-pci%2Flist%2F%3Fseries%3D96417&am
> p;d
> >
> ata=02%7C01%7Czhiqiang.hou%40nxp.com%7C0d32165274bf4c678b4808d
> 6ffa1e42
> >
> f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63697746817272
> 2471&amp;
> >
> sdata=RLgfyNRBIRePuLFTCQe4RQYleeXDevwtVN4I6ZFkS1s%3D&amp;reserv
> ed=0
> >
> > Hou Zhiqiang (20):
> >   PCI: mobiveil: Unify register accessors
> >   PCI: mobiveil: Format the code without functionality change
> >   PCI: mobiveil: Correct the returned error number
> >   PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI
> >   PCI: mobiveil: Correct PCI base address in MEM/IO outbound windows
> >   PCI: mobiveil: Replace the resource list iteration function
> >   PCI: mobiveil: Use WIN_NUM_0 explicitly for CFG outbound window
> >   PCI: mobiveil: Use the 1st inbound window for MEM inbound
> transactions
> >   PCI: mobiveil: Correct inbound/outbound window setup routines
> >   PCI: mobiveil: Fix the INTx process errors
> >   PCI: mobiveil: Correct the fixup of Class Code field
> >   PCI: mobiveil: Move the link up waiting out of mobiveil_host_init()
> >   PCI: mobiveil: Move IRQ chained handler setup out of DT parse
> >   PCI: mobiveil: Initialize Primary/Secondary/Subordinate bus numbers
> >   PCI: mobiveil: Fix the checking of valid device
> >   PCI: mobiveil: Add link up condition check
> >   PCI: mobiveil: Complete initialization of host even if no PCIe link
> >   PCI: mobiveil: Disable IB and OB windows set by bootloader
> >   PCI: mobiveil: Add 8-bit and 16-bit register accessors
> >   dt-bindings: PCI: mobiveil: Change gpio_slave and apb_csr to
> > optional
> >
> >  .../devicetree/bindings/pci/mobiveil-pcie.txt |   2 +
> >  drivers/pci/controller/pcie-mobiveil.c        | 578 +++++++++++-------
> >  2 files changed, 368 insertions(+), 212 deletions(-)
> 
> I am putting together a branch with the patches I would like to queue, for
> the ones I requested to split please wait for me, I will publish the branch and
> will ask you to rebase on top of it.
>

Ok, will split them and rebase on the new branch.

Thanks,
Zhiqiang
 
> Lorenzo