Re: [git pull] habanalabs pull request for kernel 5.3

[Oded Gabbay]

On Thu, Jul 4, 2019 at 9:41 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Jul 04, 2019 at 08:40:10AM +0200, Greg KH wrote:
> > On Thu, Jul 04, 2019 at 09:22:59AM +0300, Oded Gabbay wrote:
> > > Hello Greg,
> > >
> > > This is the pull request for habanalabs driver for kernel 5.3.
> > >
> > > It mostly contains improvements to the existing code base. Nothing too
> > > exciting this time.
> > >
> > > Please see the tag message for details on what this pull request contains.
> > >
> > > Thanks,
> > > Oded
> > >
> > > The following changes since commit 60e8523e2ea18dc0c0cea69d6c1d69a065019062:
> > >
> > >   ocxl: Allow contexts to be attached with a NULL mm (2019-07-03 21:29:47 +0200)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-next-2019-07-04
> >
> > Pulled and pushed out, thanks.
>
> Oops, no, I got the following errors from my scripts when trying to
> push:
>
> Commit a8330ecebaee2703042b95b5437511c5b2876819
>         committer SOB missing
>         dbenzoor@xxxxxxxxx oded.gabbay@xxxxxxxxx
>         Signed-off-by: Dalit Ben Zoor <dbenzoor@xxxxxxxxx>
> Commit 5a0b645318fd96d2d9c65f9b39ef07562c83a494
>         committer SOB missing
>         dbenzoor@xxxxxxxxx oded.gabbay@xxxxxxxxx
>         Signed-off-by: Dalit Ben Zoor <dbenzoor@xxxxxxxxx>
> Commit 4a0fedfc20422d83edd874040a6a965cd55d27d5
>         committer SOB missing
>         dbenzoor@xxxxxxxxx oded.gabbay@xxxxxxxxx
>         Signed-off-by: Dalit Ben Zoor <dbenzoor@xxxxxxxxx>
>
> You "reviewed" these, but as you committed the patch, you also need to
> sign off on them.
>
> Can you fix up the tree and resend?
>
> thanks,
>
> greg k-h

Sure, np, 10 minutes.
I was never really 100% sure about whether I must put sign-off if I
reviewed it, but now I know :)

Sorry for the trouble.

Thanks,
Oded