Re: [PATCH v2 4/4] net: dsa: vsc73xx: Assert reset if iCPU is enabled

From: Linus Walleij
Date: Thu Jul 04 2019 - 03:22:38 EST


On Wed, Jul 3, 2019 at 7:21 PM Pawel Dembicki <paweldembicki@xxxxxxxxx> wrote:

> Driver allow to use devices with disabled iCPU only.
>
> Some devices have pre-initialised iCPU by bootloader.
> That state make switch unmanaged. This patch force reset
> if device is in unmanaged state. In the result chip lost
> internal firmware from RAM and it can be managed.
>
> Signed-off-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

My devices do not have direct access to the reset line so I
can't assert reset no matter how I try, if it works for you, the
code is certainly better like this.

Yours,
Linus Walleij