Re: [PATCH V2 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

From: Philipp Zabel
Date: Thu Jul 04 2019 - 05:48:02 EST


On Thu, 2019-07-04 at 09:46 +0000, Anson Huang wrote:
> Hi, Philipp
>
> > On Thu, 2019-07-04 at 17:25 +0800, Anson.Huang@xxxxxxx wrote:
> > > From: Anson Huang <Anson.Huang@xxxxxxx>
> > >
> > > i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible
> > > property and related info to support i.MX8MM.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > > ---
> > > New patch.
> > > ---
> > > Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > index 13e0951..bc24c45 100644
> > > --- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > +++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > @@ -7,7 +7,7 @@ controller binding usage.
> > > Required properties:
> > > - compatible:
> > > - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
> > > - - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
> > > + - For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"
> >
> > Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a significant
> > difference is discovered later.
>
> OK, then I will add a new line as below:
>
> For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"

Yes, that looks good, thanks.

regards
Philipp