[PATCH] torture: remove exporting of internal functions

From: Denis Efremov
Date: Thu Jul 04 2019 - 08:57:30 EST


The functions torture_onoff_cleanup, torture_shuffle_cleanup are declared
as static and marked as EXPORT_SYMBOL. It's a bit confusing for an
internal function to be exported. The area of visibility for such function
is its .c file and all other modules. Other *.c files of the same module
can't use it, despite all other modules can. Relying on the fact that these
are the internal functions and they are not a crucial part of the API, the
patch removes the EXPORT_SYMBOL marking of the torture_onoff_cleanup and
torture_shuffle_cleanup. The patch complements commit cc47ae083026
("rcutorture: Abstract torture-test cleanup").

Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
---
kernel/torture.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/torture.c b/kernel/torture.c
index 17b2be9bde12..fbbcc4abe426 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -263,7 +263,6 @@ static void torture_onoff_cleanup(void)
onoff_task = NULL;
#endif /* #ifdef CONFIG_HOTPLUG_CPU */
}
-EXPORT_SYMBOL_GPL(torture_onoff_cleanup);

/*
* Print online/offline testing statistics.
@@ -449,7 +448,6 @@ static void torture_shuffle_cleanup(void)
}
shuffler_task = NULL;
}
-EXPORT_SYMBOL_GPL(torture_shuffle_cleanup);

/*
* Variables for auto-shutdown. This allows "lights out" torture runs
--
2.21.0