Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Randy Dunlap]

On 7/4/19 8:44 PM, Masahiro Yamada wrote:
> On Fri, Jul 5, 2019 at 12:23 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>
>> On 7/4/19 8:09 PM, Masahiro Yamada wrote:
>>> On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
>>> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>>>>
>>>> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>>>>
>>>>> On 7/4/19 3:01 PM, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>>>>>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
>>>>>>
>>>>>>    http://www.ozlabs.org/~akpm/mmotm/
>>>>>>
>>>>>> mmotm-readme.txt says
>>>>>>
>>>>>> README for mm-of-the-moment:
>>>>>>
>>>>>> http://www.ozlabs.org/~akpm/mmotm/
>>>>>
>>>>> I get a lot of these but don't see/know what causes them:
>>>>>
>>>>> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
>>>>> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
>>>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
>>>>> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
>>>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
>>>>>
>>>>
>>>> I checked next-20190704 tag.
>>>>
>>>> I see the empty file
>>>> drivers/gpu/drm/i915/oa/Makefile
>>>>
>>>> Did someone delete it?
>>>>
>>>
>>>
>>> I think "obj-y += oa/"
>>> in drivers/gpu/drm/i915/Makefile
>>> is redundant.
>>
>> Thanks.  It seems to be working after deleting that line.
> 
> 
> Could you check whether or not
> drivers/gpu/drm/i915/oa/Makefile exists in your source tree?

It does not.

> Your build log says it was missing.
> 
> But, commit 5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")
> added it.  (It is just an empty file)
> 
> I am just wondering why.

I am not using any git tree(s) for this.  Just patches.

That Makefile is in patch-v5.2-rc7-next-20190704.xz.

I don't know how Andrew generates the linux-next.patch file for mmotm,
but I don't see that Makefile anywhere in mmotm, although the rest of
the i915/oa/ files seems to be there.

Maybe diff skips empty files unless told to save them?

-- 
~Randy