RE: [PATCH v1 net-next] net: stmmac: enable clause 45 mdio support

From: Voon, Weifeng
Date: Fri Jul 05 2019 - 02:43:34 EST


> > If the community prefers readability
>
> Readability nearly always comes first. There is nothing performance
> critical here, MDIO is a slow bus. So the code should be readable,
> simple to understand.
>
Noted and thanks for the comments.

>
> , I will suggest to do the c45 setup in
> > both stmmac_mdio_read() and stmmac_mdio_write() 's if(C45) condition
> rather
> > than splitting into 2 new c45_read() and c45_write() functions.
>
> Fine.
>
> Andrew

I will start preparing v2. Thanks.

Weifeng