Re: [PATCH v6 2/2] KVM: LAPIC: Inject timer interrupt via posted interrupt

From: Paolo Bonzini
Date: Fri Jul 05 2019 - 12:04:16 EST


On 05/07/19 16:52, Wanpeng Li wrote:
>
> -void kvm_wait_lapic_expire(struct kvm_vcpu *vcpu)
> +void kvm_wait_lapic_expire(struct kvm_vcpu *vcpu, bool pi_inject)
> {
> struct kvm_lapic *apic = vcpu->arch.apic;
> u64 guest_tsc, tsc_deadline;
> @@ -1539,7 +1570,7 @@ void kvm_wait_lapic_expire(struct kvm_vcpu *vcpu)
> if (apic->lapic_timer.expired_tscdeadline == 0)
> return;
>
> - if (!lapic_timer_int_injected(vcpu))
> + if (!lapic_timer_int_injected(vcpu) && !pi_inject)
> return;
>

What is the reason for this other bool argument? (Yes, I hate bool
arguments...).

Paolo