Re: [PATCH] mm/slab: One function call less in verify_redzone_free()

From: David Rientjes
Date: Sat Jul 06 2019 - 18:45:45 EST


On Fri, 5 Jul 2019, Christopher Lameter wrote:

> On Fri, 5 Jul 2019, Markus Elfring wrote:
>
> > Avoid an extra function call by using a ternary operator instead of
> > a conditional statement for a string literal selection.
>
> Well. I thought the compiler does that on its own? And the tenary operator
> makes the code difficult to read.
>

Right, and I don't understand the changelog: yes, there's one less
function call in the source but functionally there's still a conditional;
this isn't even optimizing DEBUG builds.