Re: [PATCH 2/6] irqchip: Add Realtek RTD129x intc driver
From: Aleix Roca Nonell
Date: Sun Jul 07 2019 - 11:46:34 EST
On Sun, Jul 07, 2019 at 03:27:16PM +0200, Andreas FÃrber wrote:
> Am 07.07.19 um 15:22 schrieb Aleix Roca Nonell:
> > This driver adds support for the RTD1296 and RTD1295 interrupt
> > controller (intc). It is based on both the BPI-SINOVOIP project and
> > Andreas FÃrber's previous attempt to submit a similar driver.
>
> Doing that without my Signed-off-by and Copyright is certainly not okay.
> It is also lacking a clear description of what you changed from my last
> submission or the post-submission GitHub version adressing review
> comments, which broke.
I'm really sorry about that, because I rewrote the code (almost) from
scratch (given that I wasn't aware of this previous attempt when I
started working with it) I was not sure if it was necessary. I will
address this in the next version of the patch series.
Thank you and sorry for the inconvenience.
>
> Regards,
> Andreas
>
> --
> SUSE Linux GmbH
> Maxfeldstr. 5, 90409 NÃrnberg, Germany
> GF: Felix ImendÃrffer, Mary Higgins, Sri Rasiah
> HRB 21284 (AG NÃrnberg)