Re: [PATCH] irqchip: renesas-rza1: fix an use-after-free in rza1_irqc_probe()

From: Geert Uytterhoeven
Date: Mon Jul 08 2019 - 03:36:59 EST


Hi Wen,

On Mon, Jul 8, 2019 at 8:22 AM Wen Yang <wen.yang99@xxxxxxxxxx> wrote:
> The gic_node is still being used in the rza1_irqc_parse_map() call
> after the of_node_put() call, which may result in use-after-free.

Thanks! This use was added in v3, but I forgot to move the of_node_put() call.

> Fixes: a644ccb819bc ("irqchip: Add Renesas RZ/A1 Interrupt Controller driver")

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds