Re: [PATCH] tipc: ensure skb->lock is initialised

From: Eric Dumazet
Date: Mon Jul 08 2019 - 04:19:28 EST




On 7/8/19 12:53 AM, Chris Packham wrote:
> tipc_named_node_up() creates a skb list. It passes the list to
> tipc_node_xmit() which has some code paths that can call
> skb_queue_purge() which relies on the list->lock being initialised.
> Ensure tipc_named_node_up() uses skb_queue_head_init() so that the lock
> is explicitly initialised.
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>

I would rather change the faulty skb_queue_purge() to __skb_queue_purge()