Re: [PATCH] sched/topology: One function call less in build_group_from_child_sched_domain()

From: Srikar Dronamraju
Date: Mon Jul 08 2019 - 10:27:46 EST


* Enrico Weigelt, metux IT consult <lkml@xxxxxxxxx> [2019-07-08 11:38:58]:

> >
> > At runtime, Are we avoiding a function call?
> > However I think we are avoiding a branch instead of a conditional, which may
> > be beneficial.
>
> If you're assuming the compiler doesn't already optimize that (no idea
> whether gcc really does that).
>
> @Markus: could you check what gcc is actually generating out of both the
> old and your new version ?
>
>

I had already tried looking at the object files both on X86 and PowerPc and
in both cases (with and without patch) the generated code differs.

> --mtx
>
> --
> Enrico Weigelt, metux IT consult
> Free software and Linux embedded engineering
> info@xxxxxxxxx -- +49-151-27565287
>

--
Thanks and Regards
Srikar Dronamraju