Re: [PATCH 2/2] amdgpu: make SOC15/navi support conditional

[Arnd Bergmann]

On Mon, Jul 8, 2019 at 4:46 PM Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
>
> On Mon, Jul 8, 2019 at 10:42 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> >
> > Enabling amdgpu but not CONFIG_DRM_AMD_DC leads to a warning:
> >
> > drivers/gpu/drm/amd/amdgpu/nv.c: In function 'nv_set_ip_blocks':
> > drivers/gpu/drm/amd/amdgpu/nv.c:400:3: error: #warning "Enable CONFIG_DRM_AMD_DC for display support on navi." [-Werror=cpp]
> >  # warning "Enable CONFIG_DRM_AMD_DC for display support on navi."
> >    ^~~~~~~
> > drivers/gpu/drm/amd/amdgpu/soc15.c: In function 'soc15_set_ip_blocks':
> > drivers/gpu/drm/amd/amdgpu/soc15.c:653:3: error: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Werror=cpp]
> >
> > However, CONFIG_DRM_AMD_DC can only be enabled on x86, so we
> > cannot do that when building for other architectures.
>
> DC is not limited to x86.

Ah, right, only DRM_AMD_DC_DCN1_0 is x86-only.

>  I can drop the warning if that is the concern.

That would be great, yes.

      Arnd