Re: [PATCH 5/6] firmware: arm_scmi: Use the term 'message' instead of 'command'

From: Sudeep Holla
Date: Mon Jul 08 2019 - 13:25:28 EST


On Mon, Jul 08, 2019 at 05:21:29PM +0100, Steven Price wrote:
> On 08/07/2019 16:43, Sudeep Holla wrote:
> > In preparation to adding support for other two types of messages that
> > SCMI specification mentions, let's replace the term 'command' with the
> > correct term 'message'.
> >
> > As per the specification the messages are of 3 types:
> > commands(synchronous or asynchronous), delayed responses and notifications.
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> > ---
> > drivers/firmware/arm_scmi/common.h | 10 +++++-----
> > drivers/firmware/arm_scmi/driver.c | 6 +++---
> > 2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
> > index 44fd4f9404a9..4349d836b392 100644
> > --- a/drivers/firmware/arm_scmi/common.h
> > +++ b/drivers/firmware/arm_scmi/common.h
> > @@ -48,11 +48,11 @@ struct scmi_msg_resp_prot_version {
> > /**
> > * struct scmi_msg_hdr - Message(Tx/Rx) header
> > *
> > - * @id: The identifier of the command being sent
> > - * @protocol_id: The identifier of the protocol used to send @id command
> > - * @seq: The token to identify the message. when a message/command returns,
> > - * the platform returns the whole message header unmodified including
> > - * the token
> > + * @id: The identifier of the message being sent
> > + * @protocol_id: The identifier of the protocol used to send @id message
> > + * @seq: The token to identify the message. when a message returns, the]
>
> Stray ']' at the end of the line.
>

Thanks for spotting, will fix it.

--
Regards,
Sudeep