Re: [PATCH bpf] xdp: fix possible cq entry leak

[William Tu]

On Thu, Jul 4, 2019 at 11:49 PM BjÃrn TÃpel <bjorn.topel@xxxxxxxxx> wrote:
>
> On Thu, 4 Jul 2019 at 16:25, Ilya Maximets <i.maximets@xxxxxxxxxxx> wrote:
> >
> > Completion queue address reservation could not be undone.
> > In case of bad 'queue_id' or skb allocation failure, reserved entry
> > will be leaked reducing the total capacity of completion queue.
> >
> > Fix that by moving reservation to the point where failure is not
> > possible. Additionally, 'queue_id' checking moved out from the loop
> > since there is no point to check it there.
> >
>
> Good catch, Ilya! Thanks for the patch!
>
> Acked-by: BjÃrn TÃpel <bjorn.topel@xxxxxxxxx>
>
Thanks
Tested-by: William Tu <u9012063@xxxxxxxxx>