Re: [PATCH] scsi: libsas: remove the exporting of sas_wait_eh

[Jason Yan]

On 2019/7/9 0:43, Denis Efremov wrote:
> The function sas_wait_eh is declared static and marked
> EXPORT_SYMBOL, which is at best an odd combination. Because the
> function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c
> file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
>
> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
> ---
>   drivers/scsi/libsas/sas_scsi_host.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index ede0674d8399..5564d3f1243a 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -414,7 +414,6 @@ static void sas_wait_eh(struct domain_device *dev)
>   		goto retry;
>   	}
>   }
> -EXPORT_SYMBOL(sas_wait_eh);
>   
>   static int sas_queue_reset(struct domain_device *dev, int reset_type,
>   			   u64 lun, int wait)

Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>