Re: [PATCHv2 4/4] tty: n_gsm: add ioctl to map serial device to mux'ed tty

[Jiri Slaby]

On 09. 07. 19, 8:46, Martin HundebÃll  wrote:
> @@ -2623,6 +2624,9 @@ static int gsmld_ioctl(struct tty_struct *tty, struct file *file,
>  		if (copy_from_user(&c, (void *)arg, sizeof(c)))
>  			return -EFAULT;
>  		return gsm_config(gsm, &c);
> +	case GSMIOC_GETBASE:
> +		base = mux_num_to_base(gsm);
> +		return put_user(base, (int __user *)arg);

I am not sure, but do you need the local variable at all?

>  	default:
>  		return n_tty_ioctl_helper(tty, file, cmd, arg);
>  	}


-- 
js
suse labs