Re: [PATCH] drm/client: remove the exporting of drm_client_close

From: Noralf TrÃnnes
Date: Tue Jul 09 2019 - 05:43:04 EST




Den 04.07.2019 16.07, skrev Emil Velikov:
> On Thu, 4 Jul 2019 at 08:27, Denis Efremov <efremov@xxxxxxxxx> wrote:
>>
>> The function drm_client_close is declared as static and marked as
>> EXPORT_SYMBOL. It's a bit confusing for an internal function to be
>> exported. The area of visibility for such function is its .c file
>> and all other modules. Other *.c files of the same module can't use it,
>> despite all other modules can. Relying on the fact that this is the
>> internal function and it's not a crucial part of the API, the patch
>> removes the EXPORT_SYMBOL marking of drm_client_close.
>>
>> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
>
> Nice one:
> Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>

Thanks, applied.

Noralf.