Re: [PATCH v3 02/10] dt-bindings: serial: add optional pinctrl states
From: Rob Herring
Date: Tue Jul 09 2019 - 10:38:45 EST
On Thu, Jun 13, 2019 at 03:49:52PM +0200, Erwan Le Ray wrote:
> From: Bich Hemon <bich.hemon@xxxxxx>
>
> Add options for pinctrl states:
> - "sleep" for low power
> - "idle" for low power and wakeup capabilities enabled
> - "no_console_suspend" for enabling console messages in low power
>
> Signed-off-by: Bich Hemon <bich.hemon@xxxxxx>
> Signed-off-by: Erwan Le Ray <erwan.leray@xxxxxx>
>
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> index 5ec80c1..64a5ea9 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> @@ -13,7 +13,14 @@ Required properties:
> - clocks: The input clock of the USART instance
>
> Optional properties:
> -- pinctrl: The reference on the pins configuration
> +- pinctrl-names: Set to "default". An additional "sleep" state can be defined
> + to set pins in sleep state when in low power. In case the device is used as
> + a wakeup source, "idle" state is defined in order to keep RX pin active.
> + For a console device, an optional state "no_console_suspend" can be defined
> + to enable console messages during suspend. Typically, "no_console_suspend" and
> + "default" states can refer to the same pin configuration.
no_console_suspend is a linux thing and doesn't belong in DT.
Rob