Re: [PATCH net-next] net: dsa: vsc73xx: Fix Kconfig warning and build errors

From: David Miller
Date: Tue Jul 09 2019 - 17:20:30 EST


From: YueHaibing <yuehaibing@xxxxxxxxxx>
Date: Tue, 9 Jul 2019 11:02:24 +0800

> Fix Kconfig dependency warning and subsequent build errors
> caused by OF is not set:
>
> WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX
> Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=n] && NET_DSA [=m]
> Selected by [m]:
> - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y]
>
> Make NET_DSA_VITESSE_VSC73XX_SPI and NET_DSA_VITESSE_VSC73XX_PLATFORM
> depends on NET_DSA_VITESSE_VSC73XX to fix this.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Suggested-by: Andrew Lunn <andrew@xxxxxxx>
> Fixes: 95711cd5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> v2: Use "depends on" instead of "select" NET_DSA_VITESSE_VSC73XX

I ended up applying Arnd's version of this fix which was very similar.

If there is anything you want to change just submit a relative patch
on top of Arnd's change.

Thank you.