Re: [PATCH] ide: use BIT() macro for defining bit-flags

From: David Miller
Date: Tue Jul 09 2019 - 17:52:45 EST


From: Amol Surati <suratiamol@xxxxxxxxx>
Date: Sun, 7 Jul 2019 14:27:29 +0530

> The BIT() macro is available for defining the required bit-flags.
>
> Since it operates on an unsigned value and expands to an unsigned result,
> using it, instead of an expression like (1 << x), also fixes the problem
> of shifting a signed 32-bit value by 31 bits (e.g. 1 << 31).
>
> Signed-off-by: Amol Surati <suratiamol@xxxxxxxxx>

Applied, thank you.