Re: [PATCH v2 2/3] ata: make qc_prep return an int

From: Jens Axboe
Date: Tue Jul 09 2019 - 23:04:18 EST


On 7/9/19 4:02 AM, Jiri Slaby wrote:
> In case a driver wants to return an error. sata_mv is one of those --
> see the next patch.

Not against the change as such, but there seems to be some confusion on
int vs enum ata_completion_errors. The latter is probably poorly named
if you're going to start using it for prep return, but would probably
still be saner to have an AC_ERR_OK as 0 and use that and use the enum.

--
Jens Axboe